Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace local storage with zustand for new template flow #420

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

schreiaj
Copy link
Collaborator

@schreiaj schreiaj commented Nov 21, 2024

Description

Replaces local storage for intermediate storage during the new template flow.

Does not replace storing of the final templates or the storage for extract flow (those are follow ups)

Screenshots (if applicable)

N/A

Related Issues

#391

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

}
};

const handleUnmount = () => {
setDrawnFields(new Set());
setSelectedField(null);
}
// TODO: Ask Kevin what this is for, it's not clear
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh after we annotate i noticed that we need to clear those fields to prepare the the next annotation

@knguyenrise8
Copy link
Collaborator

pulled local and saving templates do not work but im guessing thats in progress.

@schreiaj schreiaj marked this pull request as ready for review November 25, 2024 15:07
@schreiaj
Copy link
Collaborator Author

pulled local and saving templates do not work but im guessing thats in progress.

Clarifying - this means it does not persist to database?

That is correct, this is a precursor to storing all the template data in the db so it is still writing that to local storage. Seemed prudent to split them up.

@schreiaj schreiaj added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 3f8cc8e Nov 25, 2024
3 checks passed
@schreiaj schreiaj deleted the schreiaj/zustand branch November 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants